Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXME: Invalid matmul code #35731

Closed
cossio opened this issue May 4, 2020 · 2 comments
Closed

FIXME: Invalid matmul code #35731

cossio opened this issue May 4, 2020 · 2 comments

Comments

@cossio
Copy link
Contributor

cossio commented May 4, 2020

I found this comment in the matrix multiplication implementation while debugging some code:

julia/stdlib/LinearAlgebra/src/matmul.jl

Line 753 in 3df8899

# FIXME: This code is completely invalid!!!

I don't know if this is wrong but that comment is scary. Why is it there?
@Liozou
Copy link
Member

Liozou commented May 4, 2020

Dup of JuliaLang/LinearAlgebra.jl#500?

@mbauman
Copy link
Member

mbauman commented May 4, 2020

Yeah, this is from #23914 and well-tracked in JuliaLang/LinearAlgebra.jl#500; it's a misuse of unsafe_wrap that is theoretically problematic.

@mbauman mbauman closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbauman @cossio @Liozou