-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eliminate base/stdlib type piracy #35899
Comments
Guess where julia/stdlib/SparseArrays/src/sparsevector.jl Line 1070 in 43d8a28
|
Would be good to collect a list of these here to track them in once place. |
There is #30945. |
It doesn't negate the overall point at all, but I believe that method is not actually necessary to concatenate vectors. Base also has an implementation. I believe that definition is to resolve an ambiguity perhaps. |
Didn't realize/remember that already existed. But yes, that's already a rather comprehensive list. |
There are a number of cases where stdlibs type pirate base (or vice versa, depending on how you look at it), which are grinding @KristofferC's gears, partly because it's just bad m'kay, but also because it means that you can't be sure whether a project doesn't depend on a stdlib just because it doesn't import it. One such example is here due to Base providing
rand
which is mostly defined in Random. Another famous example isLinearAlgebra
defining*
on matrices and vectors. It's probably not possible to eliminate the these piracies in the 1.x timeframe, but we should keep track of them and try to figure out what to do about this for Julia 2.0 when we can actually break some things.The text was updated successfully, but these errors were encountered: