Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eigencopy_oftype instead of copy_oftype #140

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

andreasnoack
Copy link
Member

Fixes #139

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (713250b) to head (dd2cede).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files          11       11           
  Lines        1645     1645           
=======================================
  Hits         1581     1581           
  Misses         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack
Copy link
Member Author

So it looks like the eigencopy_oftype is a relatively recent invention and that eigvals(Hermitian(Diagonal(...)))) used to fail before it was introduced.

@andreasnoack andreasnoack merged commit fd56d78 into master Sep 12, 2024
7 checks passed
@andreasnoack andreasnoack deleted the an/eigencopy branch September 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't compute eigenvalues of Hermitian Diagonal matrix for generic types
1 participant