Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing #55

Open
timholy opened this issue Aug 6, 2015 · 3 comments
Open

Improve testing #55

timholy opened this issue Aug 6, 2015 · 3 comments
Labels
intro-issue testing

Comments

@timholy
Copy link
Member

timholy commented Aug 6, 2015

(With contributions from @tlycken) There is lots of room for improvement in our test suite. Here are some areas that are in need of improvement:

  • Vector-valued indexing (ref Vector-valued evaluation #24, Restrict scalar indexing to Numbers #54). Test that indexing with arrays, ranges, linranges and linspaces yield the expected results. Test Colon indexing with NoInterp dimensions.
  • Exact polynomials (see e.g. discussion in WIP on cubic #90). A B-spline of degree n can be tested by interpolating data from a polynomial of the same degree, yielding results that should be exact down to the last ULP. We should test this.
  • Boundary conditions: We don't test today that e.g. an interpolant with the Flat boundary condition really has a gradient tending to 0 toward the boundary.
tomasaschan referenced this issue Sep 23, 2015
@tomasaschan
Fix type stability bug in gradient
6ebf4ca 
cc @timholy

I don't know if this is the best possible solution to the problem, but
it does allow us to do things like gradient(itp, dual(2,1)) and get an
Array{DualNumbers{Float64},1} back.

Before, that incantation would throw an InexactError because it was
trying to fit a dual number with nonzero epsilon into an Array{Float64}.
@tomasaschan
Copy link
Contributor

Referencing #24 here too; it should be closed when we fix this.

@tomasaschan tomasaschan mentioned this issue Sep 29, 2015
Closed
17 tasks
@tomasaschan tomasaschan mentioned this issue Dec 15, 2015
Merged
8 tasks
@tomasaschan tomasaschan changed the title Add tests for vector-indexing Improve testing Dec 20, 2015
@tomasaschan
Copy link
Contributor

@timholy I took the liberty of fleshing out the body of this issue a little :)

@timholy
Copy link
Member Author

timholy commented Dec 20, 2015

Very good, thanks!

@tomasaschan tomasaschan mentioned this issue Jan 11, 2016
Closed
@tomasaschan tomasaschan mentioned this issue Feb 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
intro-issue testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timholy @tomasaschan