Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we remove rem_pio2 from openspecfun? #56

Closed
ViralBShah opened this issue Dec 29, 2021 · 2 comments · Fixed by #57
Closed

Can we remove rem_pio2 from openspecfun? #56

ViralBShah opened this issue Dec 29, 2021 · 2 comments · Fixed by #57

Comments

@ViralBShah
Copy link
Member

ViralBShah commented Dec 29, 2021 •
edited
Loading

I believe we no longer use rem_pio2 from this package in SpecialFunctions.jl or anywhere else. Would it be ok to remove it altogether, especially since we have a native implementation in base?

https://github.com/JuliaLang/julia/blob/master/base/special/rem_pio2.jl

cc @stevengj @KristofferC
@ViralBShah ViralBShah changed the title rem_pio2 Remove rem_pio2 Dec 29, 2021
@ViralBShah ViralBShah changed the title Remove rem_pio2 Can we remove rem_pio2 from openspecfun? Dec 29, 2021
@ViralBShah ViralBShah mentioned this issue Dec 29, 2021
Closed
@KristofferC
Copy link
Member

Seems reasonable to me but I don't know if this project is used outside of Julia.

@ViralBShah
Copy link
Member Author

Pretty sure nobody uses it outside of Julia. I suppose they can use the older releases, as it is just a collection of amos, Fadeeva and rem_pio2.

@ViralBShah ViralBShah mentioned this issue Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove rem_pio2 JuliaMath/openspecfun
2 participants
@ViralBShah @KristofferC