-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use (inv)logcdf
in tests + update CI
#12
Conversation
If you don't want to sample from mu, another alternative is to have a larger value for the variance in order to guarantee that the sampled point is not too far way. |
@@ -73,7 +73,7 @@ Random.seed!(100) | |||
# compute OT plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps try using ν = Normal(randn(), rand()+1)
and the same for mu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's try it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work 🎉
(inv)logcdf
in tests(inv)logcdf
in tests + update CI
Pull Request Test Coverage Report for Build 1396553910
💛 - Coveralls |
Any additional comments or suggestions @davibarreira? |
Yeah, I forgot to write in the review, but I think we should sample more than one point. Like:
|
Done. |
All good. |
Pull Request Test Coverage Report for Build 1396494963Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Alternative to #11. Let's see if it is sufficient to perform computations in log space.