Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Notation of Impurity vs Charge Density #65

Closed
lmh91 opened this issue Oct 9, 2020 · 2 comments · Fixed by #141
Closed

Clarify Notation of Impurity vs Charge Density #65

lmh91 opened this issue Oct 9, 2020 · 2 comments · Fixed by #141
Labels
notation Notation and Interface
Milestone

Comments

@lmh91
Copy link
Collaborator

lmh91 commented Oct 9, 2020

Clarify notation of the terms of impurity vs charge density and the naming of the corresponding functions and variables.

@lmh91 lmh91 added the notation Notation and Interface label Oct 9, 2020
@lmh91 lmh91 added this to the v1.0.0 milestone Oct 9, 2020
@fhagemann
Copy link
Collaborator

This is a good point.
Right now, simulation.ρ is the effective charge density divided by ε0.
We might want to change the names of the fields and the corresponding functions (e.g. get_charge_density()) to avoid confusion.

@fhagemann
Copy link
Collaborator

fhagemann commented Oct 14, 2020

@lmh91 and I have decided to rename ρ to q_eff_imp as it describes the effective charge q/ε0 resulting from the ionized impurities in the depleted region.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notation Notation and Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants