Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5 IO integration #94

Closed
leenderthayen opened this issue Nov 12, 2020 · 3 comments
Closed

HDF5 IO integration #94

leenderthayen opened this issue Nov 12, 2020 · 3 comments
Assignees
Labels
convenience Improve user-friendliness

Comments

@leenderthayen
Copy link

Hello everyone,

It appears that currently the IO capabilities for HDF5 saving and loading are located in an unregistered package, LegendHDF5IO. Is it possible to integrate this directly into SSD, or if not bind the github repo's together?

Thanks!

@lmh91
Copy link
Collaborator

lmh91 commented Nov 12, 2020

So what SSD provides is a conversion (and reconversion) of several internal structs into NamedTuples.
LegendHDF5IO provides a generic IO of NamedTuples to HDF5.
You are right, this should be an LEGEND independent official registered package.
So far, we (@oschulz) had no time for this.

@fhagemann fhagemann added the convenience Improve user-friendliness label Nov 12, 2020
@oschulz
Copy link
Member

oschulz commented Nov 12, 2020

We have indeed been considering to turn (part of) LegendHDF5IO into a generic registered Julia package, but that will require some careful "surgery" and will probably still take a while. However, we wouldn't want to add heavy additional dependencies like HDF5 to SolidStateDetectors, so SolidStateDetectors still wouldn't depend on it. The current mechanism of conversion from/to NamedTuples gives the user freedom regarding which kind of I/O they want to use.

Having said that, I'm planning a custom package registry for LEGEND (since the LEGEND packages are too experiment-specific for the General registry). That will make it easier to install LegendHDF5IO in addition to SolidStateDetectors.

We should also check if JLD2 can be used out of the box (or with some tweaks) to store/load SolidStateDetectors detector definitions and fields. This may be an attractive option for non-LEGEND-users. There have been some improvements in JLD2 recently.

@leenderthayen
Copy link
Author

We are currently using JLD2, so we can close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convenience Improve user-friendliness
Projects
None yet
Development

No branches or pull requests

4 participants