Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in Plots reference images. #86

Closed
daschw opened this issue Mar 14, 2020 · 3 comments · Fixed by #89
Closed

Regression in Plots reference images. #86

daschw opened this issue Mar 14, 2020 · 3 comments · Fixed by #89
Labels
discussion

Comments

@daschw
Copy link
Member

daschw commented Mar 14, 2020

I'm afraid I see a regression with this in the Plots tests.
ticks
Compare the yticks in the first and the third subplot of the second row.
@jkrumbiegel Might this be caused by #83?
@jkrumbiegel
Copy link
Member

I guess so? I'm skipping some of the rounding because it's slow, but that didn't seem to trip up tests.
89e7316

@daschw
Copy link
Member Author

daschw commented Mar 23, 2020

Also

plot([1], [1])

ticks

looks weird. Should we revert the changes in #83?
cc: @mkborregaard @asinghvi17

@mkborregaard
Copy link
Member

Depends on whether these kinks are fixable I guess :-)

@yha yha mentioned this issue Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rounding in optimize_ticks yha/PlotUtils.jl
3 participants
@mkborregaard @daschw @jkrumbiegel