Strip whitespace before parsing in seval

[LilithHafner]

Fixes #379

I'm not sure how to add tests for this. I don't see tests from the Python side.

[cjdoris]

Thanks! You could use #379 (comment) as the basis of some tests.

[LilithHafner]

Okay, I put tests in test/utils.jl and tested this from the Julia side. Are there no CI tests with Python as the host language?

[cjdoris]

Could you move the test to

PythonCall.jl/test/jlwrap.jl

Line 189 in 5f56a9b

@testitem "module" begin

please?

[cjdoris]

Also these tests are failing because m.seval(...) returns a Py.

[cjdoris]

Are there no CI tests with Python as the host language?

There are, under pytest. These get run in CI along with the Julia tests.

Currently all the Python-side tests do is check that import juliacall doesn't raise an exception.

[LilithHafner]

My inclination would be to test this on the python side the way it came up in the wild, like this

[LilithHafner]

Where is test_import called from?

[LilithHafner]

FWIW this is not a problem in Julia 1.10+, but it's still probably worth fixing here for compatibility with 1.6/1.9.

[cjdoris]

My inclination would be to test this on the python side the way it came up in the wild, like this

I'd prefer the tests back in Julia, since that's where it's defined (it's more of a unit test that way).

[cjdoris]

Where is test_import called from?

It's called by magic. When you run the pytest program, it searches for functions called test_something and executes them.

[LilithHafner]

So I'm assuming the new function I added is also called by magic. Is that test acceptable to you or would you like me to move it back to the Julia side?

[cjdoris]

So I'm assuming the new function I added is also called by magic. Is that test acceptable to you or would you like me to move it back to the Julia side?

Yes indeed. Back to Julia please - I'd like to keep the Python tests restricted to just the things extra that JuliaCall itself gives you.

[cjdoris]

Thanks muchly!