Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review exp_overapproximation name #176

Closed
mforets opened this issue Sep 22, 2021 · 3 comments · Fixed by #193
Closed

Review exp_overapproximation name #176

mforets opened this issue Sep 22, 2021 · 3 comments · Fixed by #193

Comments

@mforets
Copy link
Member

mforets commented Sep 22, 2021

In the context of IA, all functions may overapproximate, so I suggest to rename what is now exp_overapproximate to just exp.

@schillic
Copy link
Member

I think this was meant in contrast to exp_underapproximation. I do not remember if that is really an underapproximation of the true result or (my preference) it is just an underapproximation of exp_overapproximate. Note that the docstring is not helpful because I think it just has a typo there.

exp_underapproximation(M::IntervalMatrix{T, Interval{T}}, t, p) where {T}
Overapproximation of the exponential of an interval matrix.

@lucaferranti
Copy link
Member

what is an underapproximation of an overapproximation? Is it computed by some probablistic algorithm which may leave out a portion x of the true solution set?

@schillic
Copy link
Member

No, I meant just a subset of the overapproximation.
But I checked again and I think I have to correct myself: here it is really an underapproximation of the exact result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants