Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#209 - Define state_matrix and affine_term for maps #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#209 - Define state_matrix and affine_term for maps #319

wants to merge 1 commit into from

Conversation

schillic
Copy link
Member

Closes #209.

@schillic schillic marked this pull request as ready for review January 11, 2025 11:14
@blegat
Copy link
Member

blegat commented Jan 12, 2025 •
edited
Loading

I would find constant_term more natural than affine_term. In MOI, we call the linear terms "affine tems" 😅

@schillic
Copy link
Member Author

Okay, I followed the description in #209 and chose state_matrix and affine_term because we use these names for systems too. I am worried that using a different name for maps is rather confusing.

MathematicalSystems.jl/src/systems.jl

Lines 197 to 198 in c1b8b06

state_matrix(s::$Z) = s.A
affine_term(s::$Z) = s.c

@blegat
Copy link
Member

blegat commented Jan 13, 2025

If we're already using it for systems then let's go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getter functions for map fields
2 participants
@schillic @blegat