Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird error: UndefVarError: Module not defined #79

Closed
zsoerenm opened this issue Mar 23, 2020 · 1 comment
Closed

Weird error: UndefVarError: Module not defined #79

zsoerenm opened this issue Mar 23, 2020 · 1 comment

Comments

@zsoerenm
Copy link

zsoerenm commented Mar 23, 2020

I have got a weird error with the very recent version of LoopVectorization (v0.6.22)

It says it can not find the module name in a function of the module: https://travis-ci.org/github/JuliaGNSS/GNSSSignals.jl/jobs/665945621#L325

Got exception outside of a @test
  UndefVarError: GNSSSignals not defined
  Stacktrace:
   [1] macro expansion at /home/zorn/.julia/packages/LoopVectorization/zbh4W/src/reconstruct_loopset.jl:415 [inlined]
   [2] _avx_! at /home/zorn/.julia/packages/LoopVectorization/zbh4W/src/reconstruct_loopset.jl:415 [inlined]
   [3] macro expansion at ./gcutils.jl:91 [inlined]
   [4] #fpcarrier!#10(::Int64, ::Int64, ::Val{7}, ::typeof(fpcarrier!), ::Array{Int16,1}, ::Array{Int16,1}, ::Array{Int16,1}) at /home/zorn/Documents/Code/GNSSSignals/src/carrier.jl:146

This corresponds to this line of code: https://github.com/JuliaGNSS/GNSSSignals.jl/blob/v0.12.1/src/carrier.jl#L146

I traced it back to v0.6.22.
Version v0.6.21 is not affected.

It is difficult to find a MWE for this, since it is based on the module I guess?

Using @_avx instead of @avx works as workaround for now, but it should not be needed, should it?

@chriselrod
Copy link
Member

Thanks for the report.

I changed the way @avx handles functions it doesn't recognize, because I realized that the way it was handling them sometimes made them type unstable.

I installed the penultimate commit (the one that didn't cap the LoopVectorization version), and tests pass after the latest LoopVectorization commit. It should now both work and be type stable (it may have also been type stable before, but some tests cases weren't).

I'll register the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants