Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate named kwarg in 3.x branch #507

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Deprecate named kwarg in 3.x branch #507

merged 3 commits into from
Apr 12, 2021

Conversation

palday
Copy link
Member

@palday palday commented Apr 12, 2021

cf. #469

Closes #499

@palday palday changed the base branch from main to v3.x April 12, 2021 12:03
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #507 (2c28fcf) into v3.x (efe8ec2) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

❗ Current head 2c28fcf differs from pull request most recent head 88e2e3e. Consider uploading reports for the commit 88e2e3e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             v3.x     #507      +/-   ##
==========================================
- Coverage   93.96%   93.91%   -0.05%     
==========================================
  Files          24       24              
  Lines        2103     2105       +2     
==========================================
+ Hits         1976     1977       +1     
- Misses        127      128       +1     
Impacted Files Coverage Δ
src/linearmixedmodel.jl 94.56% <66.66%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe8ec2...88e2e3e. Read the comment docs.

@palday
Copy link
Member Author

palday commented Apr 12, 2021

@ararslan This came back to haunt us, so I took your suggestion for a backport.

@palday palday requested a review from ararslan April 12, 2021 12:19
@palday palday merged commit 0cc0d29 into v3.x Apr 12, 2021
@palday palday deleted the pa/ranefnamed branch April 12, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ranef(; named=true) doesn't work for GeneralizedLinearMixedModel
2 participants