-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying sigma in LinearMixedModel #551
Conversation
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
==========================================
+ Coverage 96.16% 96.25% +0.09%
==========================================
Files 27 27
Lines 2425 2431 +6
==========================================
+ Hits 2332 2340 +8
+ Misses 93 91 -2
Continue to review full report at Codecov.
|
Co-authored-by: Douglas Bates <[email protected]>
This was done to support meta-analytic type models. There might be other cases where we can use a fixed residual variation to do tricks with observation-level random effects, but I'm not sure.
I've also done some formatting tweaks that take advantage of kwarg syntax in Julia 1.5+ (since we now require Julia 1.6).
I'll tackle #549 after this is merged (or rejected) as some of the changes would create a merge conflict.
If we one day allow specifying constraints on the betas, I would suggest doing this as a new type
ConstrainedLinearMixedModel
and then define a separateobjective
method for that so that we don't keep adding conditionals toobjective
. (And reallistically, we should should also define separatesetβ!
,setθ!
andsetβθ!
methods.)