Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for zerocorr in the bootstrap #561

Merged
merged 7 commits into from
Sep 9, 2021
Merged

Support for zerocorr in the bootstrap #561

merged 7 commits into from
Sep 9, 2021

Conversation

palday
Copy link
Member

@palday palday commented Sep 9, 2021

  • expand the type definition for the original fit (which I view as bugfix-esque, so patch)
  • added a Base.length method (technically new functionality so minor release)

Closes #560

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #561 (03011a0) into main (a06440a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files          27       27           
  Lines        2489     2490    +1     
=======================================
+ Hits         2393     2394    +1     
  Misses         96       96           
Impacted Files Coverage Δ
src/bootstrap.jl 97.85% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06440a...03011a0. Read the comment docs.

@palday palday requested a review from dmbates September 9, 2021 10:00
@palday palday merged commit 39bc79d into main Sep 9, 2021
@palday palday deleted the pa/missmeth branch September 9, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parametricbootstrap does not support zerocorr model
2 participants