Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error msg for models without random effects #651

Merged
merged 10 commits into from
Oct 6, 2022
Merged

Conversation

palday
Copy link
Member

@palday palday commented Oct 5, 2022

Thanks for contributing!

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@palday palday marked this pull request as ready for review October 5, 2022 18:26
@palday palday requested review from kleinschmidt and dmbates October 5, 2022 18:26
src/linearmixedmodel.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 94.23% // Head: 94.06% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (bc46d31) compared to base (72ac0e1).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head bc46d31 differs from pull request most recent head cfe54ce. Consider uploading reports for the commit cfe54ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   94.23%   94.06%   -0.18%     
==========================================
  Files          29       29              
  Lines        2792     2795       +3     
==========================================
- Hits         2631     2629       -2     
- Misses        161      166       +5     
Impacted Files Coverage Δ
src/linearmixedmodel.jl 98.10% <100.00%> (+<0.01%) ⬆️
src/linalg/pivot.jl 95.00% <0.00%> (-5.00%) ⬇️
src/serialization.jl 90.62% <0.00%> (-3.13%) ⬇️
src/linalg.jl 98.24% <0.00%> (-1.76%) ⬇️
src/generalizedlinearmixedmodel.jl 90.21% <0.00%> (-0.31%) ⬇️
src/remat.jl 96.73% <0.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/misc.jl Outdated Show resolved Hide resolved
@palday palday merged commit a33131c into main Oct 6, 2022
@palday palday deleted the pa/notamixed branch October 6, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants