Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fit a GLM when fixed effects are empty #657

Merged
merged 5 commits into from
Oct 26, 2022
Merged

don't fit a GLM when fixed effects are empty #657

merged 5 commits into from
Oct 26, 2022

Conversation

palday
Copy link
Member

@palday palday commented Oct 25, 2022

Thanks for contributing!

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away?

No, should be bundled in #639

If so, bump the version:

  • I've bumped the version appropriately

@palday palday requested a review from dmbates October 25, 2022 22:02
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 94.23% // Head: 94.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (072a3e9) compared to base (2c041e5).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 072a3e9 differs from pull request most recent head 264b194. Consider uploading reports for the commit 264b194 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   94.23%   94.24%           
=======================================
  Files          29       29           
  Lines        2795     2796    +1     
=======================================
+ Hits         2634     2635    +1     
  Misses        161      161           
Impacted Files Coverage Δ
src/generalizedlinearmixedmodel.jl 90.54% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.

src/generalizedlinearmixedmodel.jl Show resolved Hide resolved
@palday palday merged commit 9b645fe into main Oct 26, 2022
@palday palday deleted the pa/glmm_no_fe branch October 26, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants