-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate mulithreading in bootstrap #674
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 96.28% 95.89% -0.39%
==========================================
Files 29 29
Lines 2747 2731 -16
==========================================
- Hits 2645 2619 -26
- Misses 102 112 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the name of the function needs to be changed in a @depwarn
call in src/utilities.jl. Otherwise looks good to go. Thanks for doing this.
# no macro version yet: https://github.com/timholy/ProgressMeter.jl/issues/143 | ||
use_threads && Base.depwarn( | ||
"use_threads is deprecated and will be removed in a future release", | ||
:replicate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
:replicate, | |
:replicate |
closes #640
Did behavior change? Did you add need features? If so, please update NEWS.md
docs/NEWS-update.jl
to update the cross-references.Should we release your changes right away? If so, bump the version: