Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rank deficiency in prediction #676

Merged
merged 4 commits into from
Apr 12, 2023
Merged

support rank deficiency in prediction #676

merged 4 commits into from
Apr 12, 2023

Conversation

palday
Copy link
Member

@palday palday commented Apr 12, 2023

closes #642

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@palday palday requested a review from dmbates April 12, 2023 14:10
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e5d8a6a) 95.89% compared to head (f7ad4eb) 95.90%.

❗ Current head f7ad4eb differs from pull request most recent head 443b786. Consider uploading reports for the commit 443b786 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   95.89%   95.90%           
=======================================
  Files          29       29           
  Lines        2731     2732    +1     
=======================================
+ Hits         2619     2620    +1     
  Misses        112      112           
Impacted Files Coverage Δ
src/predict.jl 98.33% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested change in wording in the release notes.

NEWS.md Outdated Show resolved Hide resolved
@palday palday merged commit 251ef8a into main Apr 12, 2023
@palday palday deleted the pa/deficientpredict branch April 12, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

predict will give incorrect answers when newdata is rank deficient
2 participants