Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove explicit Vararg #680

Merged
merged 5 commits into from
Apr 25, 2023
Merged

remove explicit Vararg #680

merged 5 commits into from
Apr 25, 2023

Conversation

palday
Copy link
Member

@palday palday commented Apr 24, 2023

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@dmbates this should hopefully fix the mysterious warning

WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead)

@palday palday marked this pull request as ready for review April 24, 2023 15:10
@palday palday requested a review from dmbates April 24, 2023 15:11
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (564ce23) 95.90% compared to head (d5f5ea8) 95.90%.

❗ Current head d5f5ea8 differs from pull request most recent head dbb5e0e. Consider uploading reports for the commit dbb5e0e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          29       29           
  Lines        2732     2732           
=======================================
  Hits         2620     2620           
  Misses        112      112           
Impacted Files Coverage Δ
src/MixedModels.jl 100.00% <100.00%> (ø)
src/randomeffectsterm.jl 96.51% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this and for changing the pre-compilation.

@palday palday merged commit 52accc3 into main Apr 25, 2023
@palday palday deleted the pa/vararg branch April 25, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants