Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDMats implementing AbstractArray interface #40

Closed
KrisDM opened this issue Feb 11, 2016 · 4 comments
Closed

PDMats implementing AbstractArray interface #40

KrisDM opened this issue Feb 11, 2016 · 4 comments

Comments

@KrisDM
Copy link
Contributor

KrisDM commented Feb 11, 2016

Working with PDMats, it made me wonder why AbstractPDMat doesn't derive from AbstractMatrix? Given the class is immutable, we'd only have to implement getindex and size I think.

@theogf
Copy link
Contributor

theogf commented May 8, 2019

It's an old issue but any comments on this?

@davidanthoff
Copy link

@andreasnoack what is your take on this? Worth opening a PR?

@johnczito
Copy link
Member

This would be helpful. I'm currently working on kron for PDMats, and this would provide a clean fallback for any pair of arg types. Then as you said, anything else would just be a performance improvement.

@devmotion
Copy link
Member

Fixed by #105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants