This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
fix: remove total class to fix pagination bug #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The left column is total and the right column is seen resources. Notice how the total is the same and at times seen resources is higher than total. These are all for different ids so I think there is bug in the total. I'm thinking the |
zemberdotnet
commented
Sep 27, 2023
Comment on lines
381
to
387
| if (!response.resources?.length && finished !== true) { | ||
| this.logger.info( | ||
| { resourcesLength: response.resources?.length }, | ||
| 'response with zero resources, but finished is not true', | ||
| ); | ||
| finished = true; | ||
| } |
There was a problem hiding this comment.
I've put this here in case we run into the following edge case.
paginationParams.total = undefined;
total = 1000;
offset = 500;
response.resources.length = 0 || undefined;
// Seen will never grow larger, we'll get the same page forever.
seen += response.resources.length;
paginationParams.offset = seen;
I don't know if this will happen, but I want to know if it does and not create an infinite loop.
VDubber
reviewed
Sep 27, 2023
Co-authored-by: Samuel Poulton <[email protected]>
VDubber
reviewed
Sep 27, 2023
Comment on lines
+381
to
+384
| if ( | ||
| (!response.resources || response.resources.length === 0) && | ||
| !finished | ||
| ) { |
There was a problem hiding this comment.
i just noticed that response.resources.length is already accessed on line 364
Suggested change
| if ( | |
| (!response.resources || response.resources.length === 0) && | |
| !finished | |
| ) { | |
| if (response.resources.length === 0 && !finished) { |
VDubber
reviewed
Sep 27, 2023
| resourcePath, | ||
| ); | ||
|
|
||
| this.total.setValue(baseUrl, paginationParams?.total); |
There was a problem hiding this comment.
this logic was confusing. I hope it's gone forever.
VDubber
approved these changes
Sep 27, 2023
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.