Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

INT-5579 Decouple iterateApi into forEachPage and withErrorHandling #546

Merged
merged 7 commits into from
Sep 23, 2022

Conversation

i5o
Copy link
Contributor

@i5o i5o commented Sep 20, 2022

Pushed with --no-verify due to permission on my current user:

    PollyError: [Polly] [persister:JupiterOneIntegationFSPersister] Cannot persist response for [GET] https://iam.googleapis.com/v1/roles?view=FULL&showDeleted=true because the status code was 401 and `recordFailedRequests` is `false`

PollyError: [Polly] [persister:JupiterOneIntegationFSPersister] Cannot persist response for [GET] https://iam.googleapis.com/v1/roles?view=FULL&showDeleted=true because the status code was 401 and `recordFailedRequests` is `false`


    Provider API failed at https://iam.googleapis.com/v1/roles?view=FULL&showDeleted=true: 401 Unauthorized

@i5o i5o requested a review from a team as a code owner September 20, 2022 21:42
@i5o i5o added the patch Increment the patch version when merged label Sep 21, 2022
Copy link
Contributor

@ndowmon ndowmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor! I'm so glad that we can use consistent error handling in non-paginated APIs now. I've posted a few comments, but it looks like the sql-admin change is on a paginated endpoint which is no longer paginating. Can you review that and let me know if I misunderstood?

src/steps/sql-admin/client.ts Outdated Show resolved Hide resolved
src/steps/compute/client.ts Outdated Show resolved Hide resolved
src/google-cloud/client.ts Outdated Show resolved Hide resolved
src/google-cloud/client.ts Outdated Show resolved Hide resolved
src/google-cloud/client.ts Outdated Show resolved Hide resolved
src/google-cloud/client.ts Outdated Show resolved Hide resolved
@i5o i5o added released This issue/pull request has been released. release Create a release when this pr is merged and removed released This issue/pull request has been released. labels Sep 22, 2022
@i5o i5o requested a review from ndowmon September 22, 2022 15:58
@i5o i5o merged commit 913f432 into main Sep 23, 2022
@i5o i5o deleted the INT-5579 branch September 23, 2022 20:58
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v2.18.1 🚀

@j1-internal-automation j1-internal-automation added the released This issue/pull request has been released. label Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants