Int 5556 dev tools 8.24.1 #548
Conversation
Socket Security Report👍 No new dependency issues detected in pull request Socket.dev scan summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
| @@ -568,6 +568,7 @@ declare global { | |||
| } | |||
| } | |||
|
|
|||
| /* eslint-disable no-console */ | |||
There was a problem hiding this comment.
I think all of these local jest matchers could be replaced with .toTargetEntities() from the SDK, and be removed from this project. Would you be up for opening a follow-on PR to remove references of toCreateValidRelationshipsToEntities from this project?
There was a problem hiding this comment.
Hey I can do this I went ahead and created a ticket for it https://jupiterone.atlassian.net/browse/INT-5632
| @@ -2,7 +2,6 @@ import { | |||
| createMockExecutionContext, | |||
| Recording, | |||
| } from '@jupiterone/integration-sdk-testing'; | |||
| import { validateStepStartStates } from '@jupiterone/integration-sdk-runtime/dist/src/execution/validation'; | |||
There was a problem hiding this comment.
Can you provide context on why this code was copied over to this project?
There was a problem hiding this comment.
For some reason I was getting a typing error for the parameter of the this function in the last test. I could figure out how to get around it other than adding it here
There was a problem hiding this comment.
Yeah, can you please do some troubleshooting on the type error? Duplicating this code means that we'll be out-of-sync if any useful changes are introduced in the @jupiterone/integration-sdk-runtime package.
|
🚀 PR was released in |
j1-internal-automation
added
the
released
No description provided.