This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
INT-5867 Log fetch org public access prevention policy errors #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a warn statement if we receive an error when attempting to fetch organization public access prevention policies.
ndowmon
reviewed
Dec 7, 2022
src/steps/storage/index.ts
Outdated
| @@ -25,6 +25,7 @@ export async function fetchStorageBuckets( | |||
| publicAccessPreventionPolicy = | |||
| await orgPolicyClient.fetchOrganizationPublicAccessPreventionPolicy(); | |||
| } catch (err) { | |||
| logger.warn({ err }, 'Error fetching organization public access prevention policy', err); | |||
There was a problem hiding this comment.
Is the last err necessary?
Suggested change
| logger.warn({ err }, 'Error fetching organization public access prevention policy', err); | |
| logger.warn({ err }, 'Error fetching organization public access prevention policy'); |
ndowmon
previously approved these changes
Dec 7, 2022
ndowmon
approved these changes
Dec 7, 2022
JakeFerrero
deleted the
INT-5867-log-public-access-prevention-policy-errors
branch
JakeFerrero
added
patch
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warn statement if we receive an error when attempting to fetch organization public access prevention policies.