Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

FIX(int-7914) Added error handling in case dataset/tables returns 404 #588

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

Gonzalo-Avalos-Ribas
Copy link
Contributor

Added error handling in case dataset/tables returns 404

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas requested a review from a team as a code owner April 20, 2023 17:21
Copy link

@jroblesx jroblesx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, I don't know if its absolutely necessary but I feel myself more comfortable with a validation before adding the relationship.

src/steps/big-query/index.ts Show resolved Hide resolved
src/steps/big-query/index.ts Show resolved Hide resolved
@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 20, 2023
@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas merged commit 0dd9104 into main Apr 20, 2023
@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas deleted the INT-7914-dataset-404 branch April 20, 2023 21:05
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v2.23.1 🚀

@j1-internal-automation j1-internal-automation added the released This issue/pull request has been released. label Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants