Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

INT-8173: expose cloudLoggingStatus #614

Merged
merged 2 commits into from
Jul 11, 2023
Merged

INT-8173: expose cloudLoggingStatus #614

merged 2 commits into from
Jul 11, 2023

Conversation

mishelashala
Copy link

No description provided.

@mishelashala mishelashala self-assigned this Jul 10, 2023
@mishelashala mishelashala requested a review from a team as a code owner July 10, 2023 19:57
austinkelleher
austinkelleher reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@austinkelleher austinkelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we switched this to be a string instead of a boolean? Thanks!

@mishelashala
Copy link
Author

mishelashala commented Jul 11, 2023 •
edited
Loading

Can you explain why we switched this to be a string instead of a boolean? Thanks!

@austinkelleher it's part of the acceptance criteria of the ticket
But we can get back to a boolean if that makes more sense

@mishelashala
Copy link
Author

@austinkelleher I just reverted back the property to a boolean

Gonzalo-Avalos-Ribas
Gonzalo-Avalos-Ribas approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure once this merges and the integration runs that we are actually getting false values

@mishelashala mishelashala merged commit 86f5a6c into main Jul 11, 2023
@mishelashala mishelashala deleted the INT-8173/expose-cloud-logging branch July 11, 2023 17:49
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v2.30.1 🚀

@j1-internal-automation j1-internal-automation added the released This issue/pull request has been released. label Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas approved these changes

@ndowmon ndowmon Awaiting requested review from ndowmon

@adam-in-ict adam-in-ict Awaiting requested review from adam-in-ict

@austinkelleher austinkelleher Awaiting requested review from austinkelleher

Assignees

@mishelashala mishelashala

Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mishelashala @j1-internal-automation @austinkelleher @Gonzalo-Avalos-Ribas