Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Upgrading to latest integration sdk #8

Merged
merged 4 commits into from
Jun 8, 2020

Conversation

softwarewright
Copy link
Contributor

No description provided.

aiwilliams
aiwilliams previously approved these changes Jun 5, 2020
ctdio
ctdio previously approved these changes Jun 8, 2020
Copy link
Contributor

@austinkelleher austinkelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes! The only change that I request is the jest.config.js coverageThreshold be added back.

testEnvironment: 'node',
collectCoverage: true,
collectCoverageFrom: ['src/**/*.ts'],
coverageThreshold: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the coverageThreshold back? This project currently has 100% test coverage and I'd prefer to not lose that if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll add that back.

@softwarewright softwarewright dismissed stale reviews from ctdio and aiwilliams via 6c1a26f June 8, 2020 19:34
@softwarewright softwarewright merged commit 6222b1c into master Jun 8, 2020
@softwarewright softwarewright deleted the upgrade-integration-sdk branch June 8, 2020 19:36
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v5.0.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants