Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add teamId to channel entity #82

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Add teamId to channel entity #82

merged 1 commit into from
Jul 26, 2022

Conversation

zemberdotnet
Copy link
Contributor

Description

This PR adds the teamId property to the channel entity. This will enable creating mapped relationships based on webhook urls.

For a specific example, consider this response from the DigitalOcean API:

"slack": [
    {
        "channel": "Production Alerts",
        "url": "https://hooks.slack.com/services/T1234567/AAAAAAAA/ZZZZZZ%22"
    }
]

This response features the channel name (which is a unique identifier for a channel within a team), and the teamId in the url T1234567. Currently, a mapped relationship couldn't be made because an account may have multiple teams which would make the channel name insufficiently unique. If the teamId property is present on the channel, then a mapped relationships could be made using the combination of teamId and name to uniquely identify the channel to map to.

@zemberdotnet zemberdotnet requested a review from a team as a code owner July 24, 2022 15:22
@zemberdotnet zemberdotnet merged commit a243c01 into main Jul 26, 2022
@zemberdotnet zemberdotnet deleted the add-teamid-to-channel branch July 26, 2022 13:33
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v5.0.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants