Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#24 diary content api #25

Closed
wants to merge 9 commits into from
Closed

Conversation

jms0324
Copy link
Collaborator

@jms0324 jms0324 commented Apr 12, 2024

Related Issue 🍫

  • close : #[24]

Summary 🍪

  • 내가 뭘했는지
  • dto생성
  • ApiResponse 초기세팅 변경 - > code를 status로
  • SuccesType 초기세팅 변경 -> message를 "Ok"에서 "요청이 성공했습니다"로
  • ErrorType 초기세팅 변경 -> message를 "서버내부오류"로
  • Mock Mvc를 활용한 test성공 -> api 명세서와 메시지 형식이 맞는지

Before i request PR review 🍰

  • 코드리뷰로 확인 부탁하는 사항
  • 초기세팅 변경한부분들 확인해주시면 좋을 것 같아요!!

@hoeun0723
Copy link
Member

hoeun0723 commented Apr 16, 2024

image build gradle 에러가 난거 같아요 !! 확인한번 부탁드립니다!! @jms0324

@hoeun0723 hoeun0723 self-requested a review April 18, 2024 13:34
@jms0324 jms0324 closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants