From a9715744216022e3f17b574104c498bc523870af Mon Sep 17 00:00:00 2001 From: h0lybyte <5599058+h0lybyte@users.noreply.github.com> Date: Wed, 27 Nov 2024 00:58:38 -0500 Subject: [PATCH 1/2] fix(mmextensions): typo in the entry point. --- packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs b/packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs index ab65698a4..650d208bc 100644 --- a/packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs +++ b/packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs @@ -45,7 +45,7 @@ protected override void Configure(IContainerBuilder builder) builder.RegisterEntryPoint(); builder.RegisterEntryPoint(); - builder.RegisterEntryPoint(); + builder.RegisterEntryPoint(); // builder.RegisterEntryPoint(); } From a44d5f25e6efb4613123622f77a6d454a1dc2c06 Mon Sep 17 00:00:00 2001 From: h0lybyte <5599058+h0lybyte@users.noreply.github.com> Date: Wed, 27 Nov 2024 01:07:18 -0500 Subject: [PATCH 2/2] fix(mmextensions): removing the DontDestroyOnLoad for now --- .../mmextensions/Shaco/GameLifetimeScope.cs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs b/packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs index 650d208bc..426352b59 100644 --- a/packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs +++ b/packages/mmextensions/mmextensions/Shaco/GameLifetimeScope.cs @@ -36,11 +36,17 @@ protected override void Configure(IContainerBuilder builder) var cameraInstance = Object.Instantiate(cameraPrefab); cameraInstance.transform.parent = null; builder.RegisterInstance(cameraInstance).AsSelf(); - DontDestroyOnLoad(cameraInstance); + // DontDestroyOnLoad(cameraInstance); - builder.RegisterComponentInNewPrefab(gameManagerPrefab, Lifetime.Scoped).DontDestroyOnLoad(); - builder.RegisterComponentInNewPrefab(timeManagerPrefab, Lifetime.Singleton).DontDestroyOnLoad(); - builder.RegisterComponentInNewPrefab(soundManagerPrefab, Lifetime.Singleton).DontDestroyOnLoad(); + + + builder.RegisterComponentInNewPrefab(gameManagerPrefab, Lifetime.Scoped); + builder.RegisterComponentInNewPrefab(timeManagerPrefab, Lifetime.Singleton); + builder.RegisterComponentInNewPrefab(soundManagerPrefab, Lifetime.Singleton); + + // builder.RegisterComponentInNewPrefab(gameManagerPrefab, Lifetime.Scoped).DontDestroyOnLoad(); + // builder.RegisterComponentInNewPrefab(timeManagerPrefab, Lifetime.Singleton).DontDestroyOnLoad(); + // builder.RegisterComponentInNewPrefab(soundManagerPrefab, Lifetime.Singleton).DontDestroyOnLoad(); // builder.RegisterComponentInNewPrefab(cameraPrefab, Lifetime.Singleton).DontDestroyOnLoad(); builder.RegisterEntryPoint();