Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiNo generates invalid C++ code for domain 1D-powered-descent #2

Closed
miquelramirez opened this issue Oct 13, 2016 · 2 comments
Closed

Comments

@miquelramirez
Copy link

miquelramirez commented Oct 13, 2016

Hello,

after working my way around the issue with flex (downgrading to 2.5.39 from 2.6) I have stumbled onto another issue.

Invoking DiNo like this

DiNo/ex/1D-powered-descent$ ../../bin/dino descent.pddl prob_earth01.pddl --custom 1.0 5 2 --clean --force

on the first instance of the 1D Powered Descent domain results in generating invalid C++ code in the file descent.cpp, output of g++ below

Compiling executable planner, please wait...
descent.cpp:630:1: error: stray ‘\360’ in program
 {��x�}
 ^
descent.cpp:630:1: error: stray ‘\37’ in program
descent.cpp:630:1: error: stray ‘\1’ in program
descent.cpp: In member function ‘void world_class::fire_processes_plus()’:
descent.cpp:617:22: error: ‘mQ’ was not declared in this scope
   mu_thrust_clock = (mQ}
                      ^
descent.cpp:617:24: error: expected ‘)’ before ‘}’ token
   mu_thrust_clock = (mQ}
                        ^
descent.cpp:621:39: error: qualified-id in declaration before ‘(’ token
 void world_class::fire_processes_minus()
                                       ^
In file included from /home/bowman/Sandboxes/DiNo/bin/../include/upm_epilog.hpp:49:0,
                 from descent.cpp:4220:
/home/bowman/Sandboxes/DiNo/bin/../include/upm_verifier.cpp:44:1: error: expected ‘}’ at end of input
 }
 ^

See attached & compressed generated sourcefile.

It looks to me like DiNo code generator is writing a pointer to a buffer instead of the contents of the buffer.

NOTE: I am testing this on a 64-bit system, not sure if this is relevant but since I saw g++-multilib as a dependency it may be.

Cheers,

Miquel.

@miquelramirez
Copy link
Author

miquelramirez commented Oct 13, 2016

I am offering a tentative fix for this issue on this pull request.

@wmp9
Copy link
Contributor

wmp9 commented Nov 29, 2016

Fixed

@wmp9 wmp9 closed this as completed Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants