Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Skip web hook enabled modules in bot #10

Closed
HebaruSan opened this issue Jul 13, 2019 · 1 comment · Fixed by #40
Closed

[Feature] Skip web hook enabled modules in bot #10

HebaruSan opened this issue Jul 13, 2019 · 1 comment · Fixed by #40
Labels
Enhancement New feature or request

Comments

@HebaruSan
Copy link
Member

HebaruSan commented Jul 13, 2019

This is an outgrowth of KSP-CKAN/CKAN#2789 (comment). I assume that the initial functionality of the queue-based bot will be identical to NetKAN-bot, so ideas for further improvements should be submitted here for better tracking.

Motivation

If a mod's $kref is on SpaceDock, our web hook will be notified of new uploads immediately, making the bot redundant some of the time. If a mod has a $vref property, then it's still necessary to crawl it, as its KSP-AVC version file may have a "URL" property pointing to a supplemental remote version file that could be changed at any time without notifying any web hook. But if there is no $vref, then the web hook should be sufficient by itself.

Suggestion

If a module has a SpaceDock $kref and no $vref, it doesn't need to be added to the queue for inflation. Skip it.

There are 789 such modules, or about a third of the total, so this could cut the bot's total CPU load significantly.

@techman83
Copy link
Member

I like this idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants