Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parts with VARIANTs have wrong mass in catalog #93

Closed
lpgagnon opened this issue Sep 12, 2022 · 3 comments
Closed

Parts with VARIANTs have wrong mass in catalog #93

lpgagnon opened this issue Sep 12, 2022 · 3 comments
Assignees

Comments

@lpgagnon
Copy link

Feels like the sort of stock bug in kspcf's purview to fix: when a part is configured to have VARIANTs, the parts catalog only takes the VARIANT's mass into account, not the part's own mass field, resulting in too-low masses being reported. Rest of the game correctly(?) adds them up.

Example (from RO):

Originally discovered here: https://discord.com/channels/319857228905447436/319857228905447436/1004119231325032649

@NathanKell
Copy link
Contributor

Thanks I'll try to take a stab this weekend.

@NathanKell NathanKell self-assigned this Sep 23, 2022
@NathanKell
Copy link
Contributor

This is not a stock KSP bug, as can be seen by checking out a part with variants in stock KSP. It is probably an interaction with something else that does GetModuleMass things.

@NathanKell
Copy link
Contributor

@lpgagnon my hunch is that this is an RF bug, since that's what's most likely to be varying the part's mass also using GetModuleMass so if you're bored it'd be awesome if you could double check. Either way though I've confirmed it's not happening on stock Squad parts with partvariants...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants