Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations are a bit sluggish? #7

Closed
dmadisetti opened this issue Apr 11, 2024 · 11 comments
Closed

Animations are a bit sluggish? #7

dmadisetti opened this issue Apr 11, 2024 · 11 comments

Comments

@dmadisetti
Copy link
Contributor

Can we customize this, and if we can, can it be added to the docs?

Takes a good 10 seconds for things to settle for me, which is unlike my other animations

@KZDKM
Copy link
Owner

KZDKM commented Apr 11, 2024

Noted, it is already in the docs, currently the plugin uses the windows animation keyword, which should use the same configuration as windows animations. I will try to declare a new animation keyword for the overview panel. Meanwhile, try to decrease the duration of windows animation in your hyprland config file.

@dmadisetti
Copy link
Contributor Author

What are you using for reference? Here's mine:

animation=windows,1,5,overshot,slide

Reasonable at

animation=windows,1,1,overshot,slide

but not a fan of normal window animations now

@KZDKM
Copy link
Owner

KZDKM commented Apr 11, 2024

My configuration is the same as the second line. The reason why it uses windows animation is I decided it as a placeholder when I was testing the animation implementation during early development. I will try to resolve it now.

@dmadisetti
Copy link
Contributor Author

Got you. Changing workspace in overview mode is also much slower than normal change

@KZDKM
Copy link
Owner

KZDKM commented Apr 11, 2024

See this commit: e3137ae

The animation is still based on the windows animation but I added a config value for overriding the animation speed. I was not able to define a custom animation keyword (would probably look deeper into it later).

For switching workspace, the plugin just calls changeWorkspace just as the workspace dispatcher which you bind to hotkeys would do so I don't know how it would be different with overview open, could you send a video showing how it is slower?

@dmadisetti
Copy link
Contributor Author

https://www.awesomescreenshot.com/video/26642462?key=52a26a5a5af746a35ce743d634a2630c

At the end I change/ create windows normally to show how snappy it is

@dmadisetti
Copy link
Contributor Author

I will try out the new override at some point- need to get back to work for now

@dmadisetti
Copy link
Contributor Author

@KZDKM
Copy link
Owner

KZDKM commented Apr 11, 2024

Was able to reproduce. Probably caused the side effect of overriding the animated positions of windows when drawing workspace windows in overview mode which resets the animation timer of the real position. Wasn't apparent on my config so I did not notice at all. This should be a easy fix.

@KZDKM
Copy link
Owner

KZDKM commented Apr 11, 2024

Fixed with 1a3e223.

Feel free to reopen if issue persists

@KZDKM KZDKM closed this as completed Apr 11, 2024
@dmadisetti
Copy link
Contributor Author

Works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants