Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify types #104

Closed
wants to merge 1 commit into from
Closed

Simplify types #104

wants to merge 1 commit into from

Conversation

LilleAila
Copy link
Member

@LilleAila LilleAila commented Jan 11, 2025

@IldenH hva tenker du om å gjøre det på denne måten? Det blir funksjonelt ekvivalent med as ActiveMessage, som å bruke constructoren med new ActiveMessage(), da alt den gjorde var å sette this.x = input.x for alle x i input til funksjonen.

Et problem er at med as ActiveMessage vil den ikke inherite funksjonene definert under klassen, som for eksempel toPb.

@LilleAila LilleAila requested a review from IldenH January 11, 2025 18:08
@IldenH IldenH mentioned this pull request Jan 13, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant