From 5ce5832722ed20207b70114a2cf0b4b3311ecdcf Mon Sep 17 00:00:00 2001 From: LilleAila Date: Sat, 4 Jan 2025 18:52:27 +0100 Subject: [PATCH 1/2] types: properly pass outputs between jobs --- .github/workflows/pocketbase-typegen.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/pocketbase-typegen.yml b/.github/workflows/pocketbase-typegen.yml index b70ecf9..f656967 100644 --- a/.github/workflows/pocketbase-typegen.yml +++ b/.github/workflows/pocketbase-typegen.yml @@ -10,6 +10,8 @@ jobs: typegen: name: Generate pocketbase types runs-on: ubuntu-latest + outputs: + commit_changes: ${{ steps.check_changes.outputs.commit_changes }} steps: - name: Checkout code uses: actions/checkout@v4 @@ -30,6 +32,7 @@ jobs: run: make pb_types - name: Check for changes + id: check_changes # https://github.com/orgs/community/discussions/25280 run: | if git diff --quiet; then From c02bd36ff5964c68759a307143c0b6395d16e5bd Mon Sep 17 00:00:00 2001 From: LilleAila Date: Sat, 4 Jan 2025 18:57:10 +0100 Subject: [PATCH 2/2] types: fix diff condition --- .github/workflows/pocketbase-typegen.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pocketbase-typegen.yml b/.github/workflows/pocketbase-typegen.yml index f656967..1dd0c99 100644 --- a/.github/workflows/pocketbase-typegen.yml +++ b/.github/workflows/pocketbase-typegen.yml @@ -11,6 +11,7 @@ jobs: name: Generate pocketbase types runs-on: ubuntu-latest outputs: + # https://github.com/orgs/community/discussions/25280 commit_changes: ${{ steps.check_changes.outputs.commit_changes }} steps: - name: Checkout code @@ -33,9 +34,9 @@ jobs: - name: Check for changes id: check_changes - # https://github.com/orgs/community/discussions/25280 run: | - if git diff --quiet; then + # https://stackoverflow.com/a/62213712 + if [ $(git status --porcelain | wc -l ) -gt 0 ]; then echo 'commit_changes=true' >> $GITHUB_OUTPUT else echo 'commit_changes=false' >> $GITHUB_OUTPUT