Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E-Ink] Menu icons invisible when sidebar closed #3043

Closed
YodaDaCoda opened this issue Jul 5, 2024 · 0 comments · Fixed by #3047
Closed

[E-Ink] Menu icons invisible when sidebar closed #3043

YodaDaCoda opened this issue Jul 5, 2024 · 0 comments · Fixed by #3047
Assignees
@therobbiedavis
Labels
needs-triage Needs to be triaged by a developer and assigned a release UI Primarily UI impacting

Comments

@YodaDaCoda
Copy link
Contributor

Might be an issue with the base kavita styles rather than theme styling, but might require an update to the theme(s) too.

.side-nav-item.closed.active has background-color: unset which results in a white background in the e-ink theme, where it should be black, or at least theme-customisable.

Open:
image

Closed:
image
@majora2007 majora2007 transferred this issue from Kareadita/Themes Jul 7, 2024
@majora2007 majora2007 added UI Primarily UI impacting needs-triage Needs to be triaged by a developer and assigned a release labels Jul 7, 2024
therobbiedavis added a commit that referenced this issue Jul 10, 2024
@therobbiedavis
Small fix for e-ink theme
a73ddbc 
Fixes #3043
@therobbiedavis therobbiedavis mentioned this issue Jul 10, 2024
Merged
@therobbiedavis therobbiedavis self-assigned this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@therobbiedavis therobbiedavis

Labels
needs-triage Needs to be triaged by a developer and assigned a release UI Primarily UI impacting
Projects
v0.8 - PDF & Comic Love
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UX Overhaul Part 1 Kareadita/Kavita
3 participants
@YodaDaCoda @majora2007 @therobbiedavis