Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter key on text inputs don't submit forms that use vue-simple-suggest #134

Closed
2 of 9 tasks
dragospeta opened this issue Aug 30, 2019 · 3 comments · Fixed by #165
Closed
2 of 9 tasks

Enter key on text inputs don't submit forms that use vue-simple-suggest #134

dragospeta opened this issue Aug 30, 2019 · 3 comments · Fixed by #165
Labels
bug Something isn't working hacktoberfest This issue is participating in hacktoberfest help wanted Extra attention is needed patch This is a thing to include in the next patch

Comments

@dragospeta
Copy link

dragospeta commented Aug 30, 2019

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?

I'm using the vue-simple-suggest component inside a form that has a @submit.prevent event on it. If i'm pressing the enter key on a random input from the form, the form doesn't submit. I tried to set the prevent-submit prop to false, it does fix the issue but it breaks other scenarios.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

  1. Build a form that has a submit event on it
  2. Add a submit button
  3. Add a text input and a vue-simple-suggest component
  4. Press enter inside the text input

What is the expected behavior?

The form should submit.

How are you importing Vue-simple-suggest?

  • ESNext (original code, single-file .vue component, css included) (import VueSimpleSuggest from 'vue-simple-suggest/lib')
  • ES6 (import VueSimpleSuggest from 'vue-simple-suggest')
  • ES7 and above (import VueSimpleSuggest from 'vue-simple-suggest/dist/es7')
  • Bundled version (import VueSimpleSuggest from 'vue-simple-suggest')
  • CommonJS (const VueSimpleSuggest = require('vue-simple-suggest'))
  • UMD Component (<script type="text/javascript" src="https://unpkg.com/vue-simple-suggest"></script>)

What is the motivation / use case for changing the behavior?

This isn't a normal behaviour because the component breaks other basic functionalities.

Please tell us about your environment:

  • Vue.js Version: 2.5.13
  • Vue-simple-suggest version: 1.9.5
  • Browser: Chrome Version 76.0.3809.100 (Official Build) (64-bit)
  • Language: ES6
@kaskar2008
Copy link
Contributor

kaskar2008 commented Aug 30, 2019

@dragospeta Hello! Thank you for reporting about this bug :) We are aware of this issue, but for now we got no free time to fix it by ourselves. But we are open to any contribution, so feel free to make this tiny library be harder, better, faster, stronger :) But we are eager to resolve this as soon as we get free of company's internal projects 👍

@kaskar2008 kaskar2008 added bug Something isn't working help wanted Extra attention is needed patch This is a thing to include in the next patch labels Aug 30, 2019
@Raiondesu Raiondesu added the hacktoberfest This issue is participating in hacktoberfest label Oct 1, 2019
@shrpne shrpne mentioned this issue Oct 3, 2019
2 tasks
@Raiondesu
Copy link
Contributor

@all-contributors please add @dragospeta for Bug report

@allcontributors
Copy link
Contributor

@Raiondesu

I've put up a pull request to add @dragospeta! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest This issue is participating in hacktoberfest help wanted Extra attention is needed patch This is a thing to include in the next patch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants