Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSuggestions method smells & res is undefined on exception. #14

Closed
kaskar2008 opened this issue Mar 12, 2018 · 1 comment · Fixed by #21
Closed

getSuggestions method smells & res is undefined on exception. #14

kaskar2008 opened this issue Mar 12, 2018 · 1 comment · Fixed by #21
Assignees
@Raiondesu
Labels
refactoring Code smells, needs refactoring

Comments

@kaskar2008
Copy link
Contributor

getSuggestions method needs to be refactored
@kaskar2008 kaskar2008 added the refactoring Code smells, needs refactoring label Mar 12, 2018
@lauri911
Copy link

And there is little bug as well, when "await this.list(value)" gets rejected, then variable "res" will be undefined.

@Raiondesu Raiondesu changed the title getSuggestions method getSuggestions method smells Mar 30, 2018
@Raiondesu Raiondesu changed the title getSuggestions method smells getSuggestions method smells & res is undefined on exception. Mar 30, 2018
@Raiondesu Raiondesu self-assigned this Mar 30, 2018
@Raiondesu Raiondesu mentioned this issue Mar 30, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raiondesu Raiondesu

Labels
refactoring Code smells, needs refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev KazanExpress/vue-simple-suggest
3 participants
@kaskar2008 @lauri911 @Raiondesu