access log format is invalid when using gunicorn worker

[sontek]

It seems you have to pass in --access-logformat='%a %l %u %t "%r" %s %b "%{Referrer}i" "%{User-Agent}i"' to gunicorn for logging to work, they default format from gunicorn is "%(h)s %(l)s %(u)s %(t)s "%(r)s" %(s)s %(b)s "%(f)s" "%(a)s" which doesn't work with aiohttp

[zeroaltitude]

I have found this problem too, just today. Thank you for the workaround.

[FrederikNJS]

Just ran into this issue... Took me a couple of hours to find this answer. Thanks for the workaround, I was starting to get grey hairs.

[anthonylau]

benoitc/gunicorn#1300
might be related, can't get metrics on statsd

[miedzinski]

This is still an issue.

[tumb1er]

Gunicorn config defaults are invalid for aiohttp.helpers.AccessLogger.log_format. To fix this, you need to change at least %a behavior, and may be other format arguments that intersect between http://docs.gunicorn.org/en/stable/settings.html#access-log-format and http://aiohttp.readthedocs.io/en/stable/logging.html#format-specification.
This at least backward-incompatible change, but it'll be very nice to fix it finally.

Other option is to pass access logger class to RequestHandler arguments from gunicorn worker, but it's too complicated.

[asvetlov]

We can make a workaround.

1. Replace default gunicorn logger format with default aiohttp one on worker initialization.
   Follow step may be:
2. Add a checker for gunicorn logging style and raise an explicit error on worker initialization
   It can be just regexp for %(name)s parts in logging spec.

We can also add a support for gunicorn style but it requires much more work and the solution is very complicated from my perspective.

@f0t0n maybe you have an interest in fixing the issue?

[f0t0n]

@asvetlov Gunicorn's Arbiter reads the gunicorn config, then creates a logger and passes it to worker's constructor.

1. Replace default gunicorn logger format with default aiohttp one on worker initialization.

In this way if we call self.log.setFormatter() inside worker's constructor with formatter that uses default aiohttp's format string aiohttp.helpers.LOG_FORMAT we're not able to read one from gunicorn config since it's too late to override.

1. Add a checker for gunicorn logging style and raise an explicit error on worker initialization
   It can be just regexp for %(name)s parts in logging spec.

Also I don't see a correct way to retrieve a format string from logger like self.log.handlers[0].formatter._fmt since this string is a protected member of logging.Formatter class.

[tumb1er]

access_logformat from gunicorn config is passed from GunicornWebWorker to ServerHttpProtocol, which constructs AccessLogger "wrapper" with gunicorn (invalid) default format instead of aiohttp's one.

For me, access logs work with:

gunicorn --worker-class=aiohttp.worker.GunicornWebWorker 
  --access-logformat="..." 
  --log-config=logging.conf

logging.conf part:

[logger_gunicorn.access]
level=INFO
handlers=access_file
propagate=0
qualname=gunicorn.access

[handler_access_file]
class=logging.handlers.TimedRotatingFileHandler
formatter=access
args=('/data/logs/access.log', 'midnight')

[formatter_access]
format=%(message)s # That's what glogger receives from AccessLogger wrapper
class=logging.Formatter

[f0t0n]

Ok, I'll try to work with self.cfg.access_log_format.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.