Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible contribution: Token Healing #6

Open
JanIngoHaas opened this issue Sep 29, 2023 · 1 comment
Open

Possible contribution: Token Healing #6

JanIngoHaas opened this issue Sep 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@JanIngoHaas
Copy link

Hi there!
I could probably contribute a token healing sampler like it's done in guidance.
Is this a feature that you would like to see?

@KerfuffleV2
Copy link
Owner

Hi! I'd say for the most part any useful feature is very welcome.

I wasn't familiar with "token healing" but I read a little bit just now. I'm not sure if you would be able to add it here with the current interface. Currently samplers only have access to:

  1. The last generated tokens (but no way to tell which part is the initial prompt)
  2. The current logits.
  3. A random number generator.

When they run, they can only do two things: manipulate the logits and/or produce a token.

Do you think you can implement a token healing sampler within those limitations?


By the way, I'm actually really unhappy with the way resources (last tokens, logits, RNG) are implemented. I've been trying to figure out a better way to handle it without much success so far. I got a bit discouraged and haven't worked on this project for a while.

@KerfuffleV2 KerfuffleV2 added the enhancement New feature or request label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants