Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to ensure a "finish" event is dumped #36

Open
Kermalis opened this issue May 6, 2019 · 0 comments
Open

A way to ensure a "finish" event is dumped #36

Kermalis opened this issue May 6, 2019 · 0 comments

Comments

@Kermalis
Copy link
Owner

Kermalis commented May 6, 2019

When loading events, the program will stop scanning once a loop or finish is detected. However, to dump midis that match the source midi used in development of the game, there is the problem of finish events appearing after loop events. This means the finish event is missing when dumping the midi.

Possible solutions:

  • "Load to end" option that loads events after jumps in order to get a finish event. This is not ideal as the default solution since not all games will have finish events after the looping jumps.
  • Add a finish event while dumping midis if there is not one present. The problem here arises when there are events after the looping jumps aside from just the missing finish event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant