Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reconnects #49

Open
ecameracci opened this issue Apr 23, 2020 · 1 comment
Open

Handle reconnects #49

ecameracci opened this issue Apr 23, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@ecameracci
Copy link

Someone who hit back on their browser, and reconnected, was added as a separate player.

If someone was kicked, they shouldn't be able to rejoin though.

@KevinBongart
Copy link
Owner

Unfortunately that might be hard to reproduce?

Closest scenario I can think of is the player went to join a game, had to "sign up" first, then the sign up was successful and redirected to the game. Then, the player hit back, getting back to the "sign up" form, and submitted that form again which created another player and redirected to the same game (the game URL is stored in a cookie while the user is signing up, to redirect when the sign up is successful).

But if that's the case, there's a bug where someone who is logged in can access the "sign up" page, which I don't believe is possible. Could you try to reproduce these steps?

@KevinBongart KevinBongart added the bug Something isn't working label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants