Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera properties use incorrect casing according to glTF 2.0 spec #156

Closed
jasperdrescher opened this issue Apr 5, 2018 · 1 comment
Closed

Camera properties use incorrect casing according to glTF 2.0 spec #156

jasperdrescher opened this issue Apr 5, 2018 · 1 comment

Comments

@jasperdrescher
Copy link
Contributor

jasperdrescher commented Apr 5, 2018 •
edited
Loading

Hi,

While validating a glTF scene with a camera I encountered the following error:
error

So in CameraOrthographic.cs and CameraPerspective.cs the written properties are using camel casing. However, xmag, xmag, znear, and zfar should be lower case according to the glTF 2.0 spec.

It might be useful to fix this before merging this camera implementation: (#153).
@jasperdrescher jasperdrescher mentioned this issue Apr 5, 2018
Closed
@ziedbha
Copy link
Contributor

ziedbha commented Apr 6, 2018

Fixed in #158. Thanks for pointing this out!

@ericob ericob closed this as completed Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ericob @jasperdrescher @ziedbha