Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of scale/offset for texture samplers is a major limitation, should be addressed #1335

Closed
bhouston opened this issue May 7, 2018 · 3 comments

Comments

@bhouston
Copy link
Contributor

bhouston commented May 7, 2018

Just a quick note that the lack of per-texture scale and per-texture offset is a major compatibility limitation with a lot of models and it can not effectively be fixed without adding multiple UV channels to glTF, which increases the size of the files. Per-texture scale/offset are allowed in both Collada, and FBX, the two high quality transfer formats.

I have an outstanding 2-year old PR to Three.JS that enabled this as well here: mrdoob/three.js#8278

In my experience (and Clara.io has more than 1M models at this point) more than 60% of all high quality CG models utilize per-texture scaling and per-texture offsets in order to achieve their effects.

The only models that to do not generally use per-texture scale/offset is unwrapped and baked models. That is a large component of models, but it is far from the majority of all models in existence.

@lexaknyazev
Copy link
Member

The extension to support this should be ratified soon #1015.

@donmccurdy
Copy link
Contributor

In my experience (and Clara.io has more than 1M models at this point) more than 60% of all high quality CG models utilize per-texture scaling and per-texture offsets in order to achieve their effects.

Thank you, this sort of data is very valuable to us. 👍

As @lexaknyazev says we are quite close. I have an implementation for three.js, but without your PR #8278, it is of limited use.

@donmccurdy
Copy link
Contributor

Closing this issue, please track #1015 for updates. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants