Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two instructions for contribution #68

Closed
kirill-push opened this issue Oct 23, 2023 · 1 comment · Fixed by #76
Closed

Two instructions for contribution #68

kirill-push opened this issue Oct 23, 2023 · 1 comment · Fixed by #76
Assignees
@rkingsbury
Labels
docs documentation

Comments

@kirill-push
Copy link
Contributor

There is one file CONTRIBUTING.md (last update 4 month ago) in the root repository. And also there is another file docs/contributing.md (last update week ago), and they are not the same.
I noticed that and wanted to draw your attention. If that's the way it's meant to be, then sorry and please close this issue.
@rkingsbury
Copy link
Member

Thank you for pointing this out, and apologies for any confusion it may have caused. I think the extra CONTRIBUTING.md file (in the root directory) must have been added when I migrated the repo to pyscaffold.

I'll merge any relevant content from that one into the docs/ version and remove the root version soon.

@rkingsbury rkingsbury added the docs documentation label Oct 23, 2023
@rkingsbury rkingsbury self-assigned this Oct 23, 2023
@rkingsbury rkingsbury mentioned this issue Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkingsbury rkingsbury

Labels
docs documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update demo, add tutorial notebooks KingsburyLab/pyEQL
2 participants
@rkingsbury @kirill-push