Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Failing tests on MacOS #1046

Closed
8 tasks done
AndreBonda opened this issue Nov 1, 2024 · 0 comments · Fixed by #1054
Closed
8 tasks done

🚧Failing tests on MacOS #1046

AndreBonda opened this issue Nov 1, 2024 · 0 comments · Fixed by #1054
Assignees
Labels
area:testing Changes related to testing medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction

Comments

@AndreBonda
Copy link
Contributor

AndreBonda commented Nov 1, 2024

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Fix various tests that use Windows-type paths instead of cross-platform-type paths. These tests need to be passed on to any operating system.

Note

The main code being tested should be built using cross-platform pathing. If not, we should create a separate issue to address the problem. The dotnet API includes pathing checking and processing for multiple operating systems, which under the hood will use the correct \ or / characters by detecting the operating system the code is running on. We want to avoid any code that manually changes the slashes from one to another to avoid GC collections and keep things performant. Leveraging the built in dotnet API for this will achieve this desired behavior.

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

Preview Give feedback

ToDo Items

The items to complete to satisfy the Definition of Done.

Preview Give feedback

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking-changes
New Feature ✨new-feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Nov 1, 2024
@github-actions github-actions bot added the ⚕️NEEDS-TRIAGE Issue needs to be looked at and processed by a team member label Nov 1, 2024
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team Nov 4, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.39 milestone Nov 4, 2024
@CalvinWilkinson CalvinWilkinson added tech-debt Code refactoring or cleanup / tech debt reduction medium-priority Medium Priority preview Done while in preview area:testing Changes related to testing and removed ⚕️NEEDS-TRIAGE Issue needs to be looked at and processed by a team member labels Nov 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗️In Development to ✅Done in KD-Team Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:testing Changes related to testing medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants