Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for renaming #43

Open
vadimeisenbergibm opened this issue Feb 22, 2017 · 2 comments
Open

Proposal for renaming #43

vadimeisenbergibm opened this issue Feb 22, 2017 · 2 comments
Labels
enhancement

Comments

@vadimeisenbergibm
Copy link
Contributor

Credentials -> AuthenticationMiddleware It is immediately clear what this class is.
Alternative names - AuthenticationRouterMiddleware. I am fine with the package name as it is now, since it can be any "brand" name - like passport.

CredentialsPluginProtocol -> AuthenticationMiddlwarePlugin.

In the README - Facebook OAuth2 token -> Facebook OAuth2 Access Token based flow or Facebook OAuth2 Bearer Token based flow or Facebook OAuth2 Access Token based authentication. Any description except from plain "Token" word.
@vadimeisenbergibm
Copy link
Contributor Author

@shmuelk @irar2 your comments are welcome.

@gmosx
Copy link

gmosx commented Oct 1, 2017

I like more descriptive names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gmosx @gtaban @vadimeisenbergibm